We cut a release branch for the 1.7.0 release.
Our plan from this point is roughly:
- Phase 1 (until 10/13): work on finalizing the release branch
- Phase 2 (after 10/13): perform extended integration/stability/performance testing based on Release Candidate builds.
This issue is for tracking cherry-picks to the release branch.
Phase 1 (until 10/13):
Only low-risk changes may be cherry-picked from master:
- Fixes to regressions against PyTorch 1.0+
- Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
- Fixes to new features being introduced in this release
- Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
- Test/CI fixes or improvements
- Documentation improvements
- Release branch specific changes (e.g. change version identifiers, remove/hide features that aren’t ready for release)
Any other change requires special dispensation from the release managers (currently @malfet, @seemethere, @gchanan). If this applies to your change please write “Special Dispensation” in the “Criteria Category:” template below and explain.
Phase 2 (after 10/13):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are:
This will likely require a discussion with the larger release team over VC or Slack.
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch. Note that you should use the normal github workflow for this; ghstack does not support release branches.
Make a request below with the following template:
Link to landed master PR (if applicable): Link to release branch PR: Criteria Category:
Someone from the release team will reply with approved / denied or ask for more information
If approved, someone from the release team will merge your PR once the tests pass. NOTE: do not land the release branch PR yourself. Our normal landing tools (ghimport, phabricator, etc.) do not work on the release branch.