A trivial detail. I always get blank THREE.WebGLProgram: gl.getProgramInfoLog() warning messages from 18057 of 89 (and equivalents in earlier versions). These would disappear if you change
18055 } else if ( programLog !== ” ) {
to
18055 } else if ( programLog.trim() !== ” ) {
The trim() means we don’t get warnings if the InfoLog is a blank space.
It’s great to get rid of unnecessary warnings so I can concentrate on all those that are due to my errors.
Or maybe there’s a reason why we should be warned if the log gives us a blank space, but I can’t think why or what to do about it.
Thanks as always
Steven
Three.js version
- Dev
- r89
- …
Browser
- [] All of them
- Chrome
- [X ] Firefox
- Internet Explorer
OS
- [] All of them
- [x ] Windows
- macOS
- Linux
- Android
- iOS
Hardware Requirements (graphics card, VR Device, …)
Rift
I’ve created a PR to perform at least a simple trim on the info log messages. This is something we can safely do without any performance hits.