Clean up XLoader

2 thoughts on “Clean up XLoader”

1. For example,

   wrong intents

   three.js/examples/js/loaders/XLoader.js

   Lines 1445 to 1481
   in
   53e3b1b

   	if ( this.loadingXdata.FrameInfo_Raw[ nowFrameName ].BoneInfs != null && this.loadingXdata.FrameInfo_Raw[ nowFrameName ].BoneInfs.length ) {
   	var keys = Object.keys( this.loadingXdata.FrameInfo_Raw );
   	var BoneDics_Name = [];
   	for ( var m = 0; m < keys.length; m ++ ) {
   	if ( this.loadingXdata.FrameInfo_Raw[ keys[ m ] ].FrameStartLv <= this.loadingXdata.FrameInfo_Raw[ nowFrameName ].FrameStartLv && nowFrameName != keys[ m ] ) {
   	continue;
   	}
   	var b = new THREE.Bone();
   	b.name = keys[ m ];
   	b.applyMatrix( this.loadingXdata.FrameInfo_Raw[ keys[ m ] ].FrameTransformMatrix );
   	BoneDics_Name[ b.name ] = putBones.length;
   	putBones.push( b );
   	var ivm = new THREE.Matrix4();
   	ivm.getInverse( this.loadingXdata.FrameInfo_Raw[ keys[ m ] ].FrameTransformMatrix );
   	BoneInverse.push( ivm );
   	}
   	for ( var _m = 0; _m < putBones.length; _m ++ ) {
   	for ( var dx = 0; dx < this.loadingXdata.FrameInfo_Raw[ putBones[ _m ].name ].children.length; dx ++ ) {
   	var nowBoneIndex = BoneDics_Name[ this.loadingXdata.FrameInfo_Raw[ putBones[ _m ].name ].children[ dx ] ];
   	if ( putBones[ nowBoneIndex ] != null ) {
   	putBones[ _m ].add( putBones[ nowBoneIndex ] );
   	}
   	}
   	}
   	}

   wrong spaces

   three.js/examples/js/loaders/XLoader.js

   Line 425
   in
   53e3b1b

   this .endLineCount++;

   wrong reference (maybe)

   three.js/examples/js/loaders/XLoader.js

   Line 394
   in
   53e3b1b

   return parseASCII( String.fromCharCode.apply( null, data ) );

   And I want it to

   • be entirely readable more (or we need comment)
   • follow the code style

2. @adrs2002 I wouldn’t say is bad quality, but it sure has some issues… For example, it creates a lot of functions in global scope which could collide with user’s code.

   I think https://github.com/mrdoob/three.js/blob/dev/examples/js/loaders/MD2Loader.js and https://github.com/mrdoob/three.js/blob/dev/examples/js/loaders/PlayCanvasLoader.js are good examples of my preferred structure for loaders.

   Single object with load and parse as public methods.

Comments are closed.