Atom built from source (v1.34) crashes when opening a folder with git repository

Edit by @rsese to add extra notes

Reproduced on Ubuntu 16.04 but couldn’t reproduce on 18.04.

On 16.04, used node 8.9.3 and npm 6.2.0:

$ apm -v
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.34.0
python 2.7.12

Used the same node and npm versions on 18.04.


Description

Atom crashes when opening a folder containing a git repository

Steps to Reproduce

  1. Build Atom from source (v1.34) “./script/build –create-debian-package”
  2. Install your build
  3. Start Atom
  4. Open a folder containing git repository

Expected behavior:

Actual behavior:
Crashes

Reproduces how often:
Always

Versions

OS: Ubuntu 16.04 LTS

building with:
Node: v8.9.3
Npm: v5.5.1

checks during build:
apm 2.1.3
npm 6.2.0
node 8.9.3 x64
python 2.7.12
git 2.7.4

after installing built package:
atom –version
Atom : 1.34.0
Electron: 2.0.16
Chrome : 61.0.3163.100
Node : 8.9.3

apm –version
apm 2.1.3
npm 6.2.0
node 8.9.3 x64
atom 1.34.0
python 2.7.12
git 2.7.4

Additional Information

Seems related to nsfw package.
Noticed that my build produces different(bigger) nsfw.node file than the one from official release (118K vs 102K)
./resources/app.asar.unpacked/node_modules/@atom/nsfw/build/Release
Instructions from manual were followed.

Crash log:
_usr_share_atom_atom.1000.zip

1 possible answer(s) on “Atom built from source (v1.34) crashes when opening a folder with git repository

  1. Since we don’t know what’s causing these crashes, our best bet might be to find a recent version of Atom where this problem does not occur, and then use git bisect to find the commit that introduced the problem. Here’s what I’m seeing so far:

    • 💥 Atom 1.34.0: Crashes
    • 💥 Atom 1.33.0: Crashes
    • 💥 Atom 1.32.2: Crashes
    • Atom 1.31.2: Does not crash

    It’ll probably take a while to run through the git bisect process, but I hope to kick it off this week.